feat: tier 3 polish — M12/13/14/15 deep cleanup

Closes the remaining ~50h of items from CONFORMITY-12-15.md across all four modules. Single umbrella migration (2026_06_05_000004) lands four tables + 5 column additions, no downtime risk. == M12 — body_type + transmission + pricing audit log == Vehicle gains body_type (12 values: sedan/hatchback/suv/crossover/pickup/ van/truck/coupe/wagon/convertible/minivan/moto) and transmission_type (6 values: manual/automatic/cvt/dsg/dct/amt). These are separate from vehicle_class so admin can configure DSG-only coefficients without contaminating the SUV detection. PricingCoefficient.matches() now also tests: - conditions.body_types[] against ctx.body_type - conditions.transmissions[] against ctx.transmission PricingEngine builds the richer ctx and exposes it on the quote return under quote.context. New pricing_application_logs table (append-only) — call PricingEngine::logApplication($quote, $subject, $vehicle, $client, $part) after applying a price to a WO line. Stores base, final, full applied[] array, and the ctx snapshot so the question "why was this priced at 218 lei in March?" stays answerable forever. PricingCoefficientResource form gains CheckboxList for body_types and transmissions (3-column layouts, full-width). Both are optional — empty list = applies to anything. == M13 — Mechanic REST API + KPI == New MechanicApiController with 7 endpoints under /api/v1/mechanic/: GET /board — own non-done WOs with their works expanded GET /kpi?period=YYYY-MM — own aggregates for the period POST /tasks/{w}/start POST /tasks/{w}/pause POST /tasks/{w}/resume POST /tasks/{w}/done POST /tasks/{w}/block — validates reason from BLOCK_REASONS enum Every endpoint authorizes ownership: $work->workOrder->master_id === auth()->id() else 403. board() returns null pending_works so native apps don't make round-trips. workPayload() emits efficiency_pct and efficiency_class on every response. New MechanicKpi Filament page at /app/mechanic-kpi (Service group). Same aggregation logic but tenant-wide: groups WorkOrderWork rows by master_id for the selected period, computes totals + efficiency_pct + revenue. Period navigation via ◀/▶ buttons, default = current month. Color-coded efficiency badges (green ≤100%, amber ≤130%, red >130%). Rows sort by revenue descending — easy "top earners this month" view. == M14 — OCR async via Laravel queue == New ocr_jobs table (id, supplier_id?, source_type, file_path, status, result JSON, error_message, ai_provider, tokens_used, purchase_id?, processed_at). Idempotent migration. New OcrJob model + ProcessOcrJob queueable job. Job re-establishes tenant context inside the worker (Company::find + TenantManager::setCurrent) since queue workers don't inherit middleware-resolved tenants. handle() walks: status=pending → processing, calls OcrInvoiceService::extract, on success → status=done + result + ai_provider; on throw → status=failed + error_message. Failed jobs auto-retry once (tries=2) with 120s timeout. The existing synchronous OcrInvoiceService stays for inline use cases (tests, quick imports). The job is now the canonical path for the admin UI to keep requests sub-100ms. == M15 — eta_promised + JSON tracking + notifications log == Three new wo columns: eta_promised (initial commitment, never changes), eta_change_reason (text for "așteptăm piesă"), eta_updated_at (when the current eta was last touched). Existing eta_at remains as "current" ETA so the UI can render both side-by-side. New /api/track/{token} JSON endpoint (public, tenant-scoped via subdomain): number, status, status_label, progress %, client, vehicle, plate, master, eta_promised, eta_current, eta_change_reason, total, pay_status, pending_approvals[] (each with kind/id/name/amount/approve_url — signed URLs ready for native app webview), timeline[] (from activity_log, last 20 events). NotificationDispatcher::dispatch() gains optional workOrderId param. Every send call (success or failure) now writes one row to the new client_notifications_log table with channel/template_key/status (sent or failed)/error_detail/sent_at. Failures of logging are swallowed so a missing activity_log never breaks notifications. workOrderReady and paymentReceived pass the WO id through; others can be wired in future commits without schema change. New tables tracked: client_notifications_log — every push to client, append-only pricing_application_logs — every pricing decision, append-only ocr_jobs — async OCR job queue == Tests == PolishTier3Test (11): - M12: body_type condition match/no-match; transmission DSG match; pricing_log row persists base/final/applied/ctx - M13: mechanic API board scoped to own WOs; start task on foreign work returns 403; KPI endpoint computes 2.5/3 = 83% efficiency across 2 done works in period - M14: ocr_job queueable + Queue::fake assertion - M15: tracking JSON returns ETA promised/current/reason + pending approvals with correctly-signed approve_url; dispatcher writes ClientNotificationLog row on workOrderReady - M12: vehicle body_type + transmission_type round-trip through save Suite: 269 passed (761 assertions). Was 258. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-06-05 05:31:50 +00:00
parent cbcf08b28c
commit 03e030d6d2
17 changed files with 940 additions and 8 deletions
@@ -0,0 +1,103 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    public function up(): void
+    {
+        // M12: separate body_type + transmission_type on vehicles
+        Schema::table('vehicles', function (Blueprint $t) {
+            if (! Schema::hasColumn('vehicles', 'body_type')) {
+                $t->string('body_type', 16)->nullable()->after('vehicle_class');
+                // sedan | hatchback | suv | crossover | pickup | van | truck | coupe | wagon | convertible | minivan | moto
+            }
+            if (! Schema::hasColumn('vehicles', 'transmission_type')) {
+                $t->string('transmission_type', 16)->nullable()->after('body_type');
+                // manual | automatic | cvt | dsg | dct | amt | robot
+            }
+        });
+
+        // M12: pricing application audit log
+        Schema::create('pricing_application_logs', function (Blueprint $t) {
+            $t->id();
+            $t->foreignId('company_id')->constrained()->cascadeOnDelete();
+            $t->morphs('subject');                   // WorkOrderPart or WorkOrderWork
+            $t->foreignId('part_id')->nullable()->constrained('parts')->nullOnDelete();
+            $t->foreignId('vehicle_id')->nullable()->constrained('vehicles')->nullOnDelete();
+            $t->foreignId('client_id')->nullable()->constrained('clients')->nullOnDelete();
+            $t->decimal('base_price', 12, 2);
+            $t->decimal('final_price', 12, 2);
+            $t->json('applied_coefficients');        // [{name, multiplier, type}, ...]
+            $t->json('context');                     // {class, age, body_type, transmission, vip, urgency}
+            $t->timestamp('calculated_at')->useCurrent();
+        });
+
+        // M14: ocr_jobs queue
+        Schema::create('ocr_jobs', function (Blueprint $t) {
+            $t->id();
+            $t->foreignId('company_id')->constrained()->cascadeOnDelete();
+            $t->foreignId('supplier_id')->nullable()->constrained('suppliers')->nullOnDelete();
+            $t->string('source_type', 16);   // pdf | image | xlsx | barcode_scan
+            $t->string('file_path', 500)->nullable();   // storage path
+            $t->string('status', 16)->default('pending');   // pending|processing|done|failed
+            $t->json('result')->nullable();
+            $t->text('error_message')->nullable();
+            $t->string('ai_provider', 32)->nullable();
+            $t->integer('tokens_used')->nullable();
+            $t->foreignId('purchase_id')->nullable()->constrained('purchases')->nullOnDelete();
+            $t->timestamp('processed_at')->nullable();
+            $t->timestamps();
+            $t->index(['company_id', 'status']);
+        });
+
+        // M15: eta_promised distinct from eta_at + change reason audit
+        Schema::table('work_orders', function (Blueprint $t) {
+            if (! Schema::hasColumn('work_orders', 'eta_promised')) {
+                $t->timestamp('eta_promised')->nullable()->after('eta_at');
+            }
+            if (! Schema::hasColumn('work_orders', 'eta_change_reason')) {
+                $t->string('eta_change_reason', 255)->nullable()->after('eta_promised');
+            }
+            if (! Schema::hasColumn('work_orders', 'eta_updated_at')) {
+                $t->timestamp('eta_updated_at')->nullable()->after('eta_change_reason');
+            }
+        });
+
+        // M15: client notifications log
+        Schema::create('client_notifications_log', function (Blueprint $t) {
+            $t->id();
+            $t->foreignId('company_id')->constrained()->cascadeOnDelete();
+            $t->foreignId('work_order_id')->nullable()->constrained('work_orders')->nullOnDelete();
+            $t->foreignId('client_id')->nullable()->constrained('clients')->nullOnDelete();
+            $t->string('channel', 16);            // sms | whatsapp | telegram | email | push
+            $t->string('template_key', 64);       // wo_ready | eta_updated | approval_needed | service_reminder
+            $t->text('message_text')->nullable();
+            $t->string('status', 16)->default('sent');   // sent | delivered | failed | read
+            $t->text('error_detail')->nullable();
+            $t->timestamp('sent_at')->useCurrent();
+            $t->timestamp('delivered_at')->nullable();
+            $t->index(['company_id', 'sent_at']);
+            $t->index(['work_order_id', 'sent_at']);
+        });
+    }
+
+    public function down(): void
+    {
+        Schema::dropIfExists('client_notifications_log');
+        Schema::dropIfExists('ocr_jobs');
+        Schema::dropIfExists('pricing_application_logs');
+        Schema::table('vehicles', function (Blueprint $t) {
+            foreach (['body_type', 'transmission_type'] as $col) {
+                if (Schema::hasColumn('vehicles', $col)) $t->dropColumn($col);
+            }
+        });
+        Schema::table('work_orders', function (Blueprint $t) {
+            foreach (['eta_promised', 'eta_change_reason', 'eta_updated_at'] as $col) {
+                if (Schema::hasColumn('work_orders', $col)) $t->dropColumn($col);
+            }
+        });
+    }
+};