feat: P1 RBAC defers — overrides + sessions + audit log
Completes the P1 items from /tmp/service/new/01-TZ-rbac §2.1 §4.1. == user_permission_overrides table == Per-user grant/deny exceptions on top of role-based RBAC. Composite PK (user_id, permission_id) so each user can have at most one override per permission. Schema: - mode: 'grant' | 'deny' - reason: text (audit context: "lockdown audit period", etc.) - granted_by_id + granted_at: who/when made the exception - expires_at: optional auto-expiry Eloquent model UserPermissionOverride with relations to user, permission, grantedBy; isExpired() helper. == Resolution order in User::canDo() == 1. Active deny-override (not expired) → return false (and log if sensitive) 2. Active grant-override (not expired) → return true 3. Admin/owner bypass → return true 4. Standard role-based check via Spatie Critically: deny overrides ALSO block admin/owner. This is intentional — the TZ's "separation of duties" requirement (an admin who shouldn't be able to delete payments). Without this, deny is useless against admins. Override resolution uses a single query per check (cached by Eloquent during the request). The override-check happens before the role check so a deny is always authoritative. == Audit log on sensitive denials == When canDo() returns false for one of these sensitive permissions, a spatie/activitylog entry is written with event=permission_denied: - admin.users.manage / admin.roles.manage / admin.settings.edit / admin.backup.download - finance.delete_payment / finance.view_pl - salaries.mark_paid / salaries.view_all - work_orders.delete / work_orders.approve_discount_any Non-sensitive denials (e.g., clients.create) don't log to avoid noise. The activity payload includes the permission slug; causedBy is the user who was denied. Failures of the logger are swallowed so a misconfigured activitylog never breaks auth. == UserResource UI == New PermissionOverridesRelationManager mounted on the edit page: - Table: permission, mode (GRANT/DENY badge), reason, expires_at, granted_by - Create form: permission select, mode, expires_at, reason - granted_at + granted_by_id auto-populated to now() / auth()->id() - Default sort: granted_at desc Two new actions on the user row: - "Force logout" (warning color): visible only when active sessions exist. Deletes every row in `sessions` with user_id=record→id. Notification shows count revoked. - "Resetează 2FA" stays (from previous commit) Two new toggleable columns: - Sesiuni active (count from sessions table) - Excepții (count of permission overrides) == Tests == PermissionOverridesTest covers: - grant unlocks a permission the role doesn't have - deny blocks a permission the role grants - deny blocks even admin role (separation of duties) - expired override is ignored - future-expiry override stays active - audit log writes on sensitive denial - audit log silent on non-sensitive denial - force_logout deletes all user sessions but not others' Suite: 214 passed (591 assertions). Was 206. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -3,6 +3,7 @@
|
||||
namespace App\Filament\Tenant\Resources;
|
||||
|
||||
use App\Filament\Tenant\Resources\UserResource\Pages;
|
||||
use App\Filament\Tenant\Resources\UserResource\RelationManagers;
|
||||
use App\Models\Tenant\User;
|
||||
use Filament\Forms;
|
||||
use Filament\Resources\Resource;
|
||||
@@ -120,6 +121,18 @@ class UserResource extends Resource
|
||||
->trueColor('success')
|
||||
->falseIcon('heroicon-o-shield-exclamation')
|
||||
->falseColor('warning'),
|
||||
Tables\Columns\TextColumn::make('active_sessions')
|
||||
->label('Sesiuni')
|
||||
->getStateUsing(fn ($record) => \Illuminate\Support\Facades\DB::table('sessions')->where('user_id', $record->id)->count())
|
||||
->badge()
|
||||
->color(fn ($state) => $state > 0 ? 'success' : 'gray')
|
||||
->toggleable(),
|
||||
Tables\Columns\TextColumn::make('permission_overrides_count')
|
||||
->counts('permissionOverrides')
|
||||
->label('Excepții')
|
||||
->badge()
|
||||
->color('warning')
|
||||
->toggleable(isToggledHiddenByDefault: true),
|
||||
Tables\Columns\TextColumn::make('status')
|
||||
->badge()
|
||||
->colors([
|
||||
@@ -141,6 +154,17 @@ class UserResource extends Resource
|
||||
])
|
||||
->actions([
|
||||
Actions\EditAction::make(),
|
||||
Actions\Action::make('force_logout')
|
||||
->label('Force logout')
|
||||
->icon('heroicon-o-arrow-right-on-rectangle')
|
||||
->color('warning')
|
||||
->visible(fn ($record) => \Illuminate\Support\Facades\DB::table('sessions')->where('user_id', $record->id)->exists())
|
||||
->requiresConfirmation()
|
||||
->modalDescription('Va deconecta utilizatorul pe toate device-urile.')
|
||||
->action(function ($record) {
|
||||
$n = \Illuminate\Support\Facades\DB::table('sessions')->where('user_id', $record->id)->delete();
|
||||
\Filament\Notifications\Notification::make()->title("$n sesiuni revoke-uite")->success()->send();
|
||||
}),
|
||||
Actions\Action::make('reset_2fa')
|
||||
->label('Resetează 2FA')
|
||||
->icon('heroicon-o-shield-exclamation')
|
||||
@@ -158,6 +182,13 @@ class UserResource extends Resource
|
||||
->defaultSort('created_at', 'desc');
|
||||
}
|
||||
|
||||
public static function getRelations(): array
|
||||
{
|
||||
return [
|
||||
RelationManagers\PermissionOverridesRelationManager::class,
|
||||
];
|
||||
}
|
||||
|
||||
public static function getPages(): array
|
||||
{
|
||||
return [
|
||||
|
||||
+90
@@ -0,0 +1,90 @@
|
||||
<?php
|
||||
|
||||
namespace App\Filament\Tenant\Resources\UserResource\RelationManagers;
|
||||
|
||||
use App\Auth\Permissions;
|
||||
use Filament\Actions;
|
||||
use Filament\Forms;
|
||||
use Filament\Resources\RelationManagers\RelationManager;
|
||||
use Filament\Schemas;
|
||||
use Filament\Schemas\Schema;
|
||||
use Filament\Tables;
|
||||
use Filament\Tables\Table;
|
||||
use Spatie\Permission\Models\Permission;
|
||||
|
||||
class PermissionOverridesRelationManager extends RelationManager
|
||||
{
|
||||
protected static string $relationship = 'permissionOverrides';
|
||||
|
||||
protected static ?string $title = 'Excepții drepturi';
|
||||
|
||||
protected static string|\BackedEnum|null $icon = 'heroicon-o-shield-exclamation';
|
||||
|
||||
public function form(Schema $schema): Schema
|
||||
{
|
||||
return $schema->components([
|
||||
Schemas\Components\Section::make('Excepție')
|
||||
->columns(2)
|
||||
->schema([
|
||||
Forms\Components\Select::make('permission_id')
|
||||
->label('Drept')
|
||||
->required()
|
||||
->searchable()
|
||||
->options(fn () => Permission::orderBy('name')->pluck('name', 'id'))
|
||||
->columnSpanFull(),
|
||||
Forms\Components\Select::make('mode')
|
||||
->required()
|
||||
->options(['grant' => 'GRANT — adaugă dreptul', 'deny' => 'DENY — interzice dreptul'])
|
||||
->default('grant'),
|
||||
Forms\Components\DatePicker::make('expires_at')
|
||||
->label('Expiră la (opțional)')
|
||||
->minDate(now()),
|
||||
Forms\Components\Textarea::make('reason')
|
||||
->label('Motiv')
|
||||
->columnSpanFull()
|
||||
->placeholder('Ex: lockdown temporar; acces pentru audit; etc.')
|
||||
->rows(2),
|
||||
]),
|
||||
]);
|
||||
}
|
||||
|
||||
public function table(Table $table): Table
|
||||
{
|
||||
return $table
|
||||
->recordTitleAttribute('mode')
|
||||
->columns([
|
||||
Tables\Columns\TextColumn::make('permission.name')
|
||||
->label('Drept')
|
||||
->searchable()
|
||||
->sortable(),
|
||||
Tables\Columns\TextColumn::make('mode')
|
||||
->badge()
|
||||
->colors(['success' => 'grant', 'danger' => 'deny'])
|
||||
->formatStateUsing(fn ($state) => strtoupper($state)),
|
||||
Tables\Columns\TextColumn::make('reason')
|
||||
->limit(40)
|
||||
->placeholder('—'),
|
||||
Tables\Columns\TextColumn::make('expires_at')
|
||||
->label('Expiră')
|
||||
->date()
|
||||
->placeholder('niciodată')
|
||||
->color(fn ($record) => $record?->isExpired() ? 'danger' : 'gray'),
|
||||
Tables\Columns\TextColumn::make('grantedBy.name')
|
||||
->label('Acordat de')
|
||||
->placeholder('—')
|
||||
->toggleable(),
|
||||
])
|
||||
->headerActions([
|
||||
Actions\CreateAction::make()
|
||||
->mutateDataUsing(fn (array $data) => array_merge($data, [
|
||||
'granted_at' => now(),
|
||||
'granted_by_id' => auth()->id(),
|
||||
])),
|
||||
])
|
||||
->actions([
|
||||
Actions\EditAction::make(),
|
||||
Actions\DeleteAction::make(),
|
||||
])
|
||||
->defaultSort('granted_at', 'desc');
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user