feat: P1 RBAC defers — overrides + sessions + audit log

Completes the P1 items from /tmp/service/new/01-TZ-rbac §2.1 §4.1.

== user_permission_overrides table ==
Per-user grant/deny exceptions on top of role-based RBAC. Composite PK
(user_id, permission_id) so each user can have at most one override per
permission. Schema:
- mode: 'grant' | 'deny'
- reason: text (audit context: "lockdown audit period", etc.)
- granted_by_id + granted_at: who/when made the exception
- expires_at: optional auto-expiry

Eloquent model UserPermissionOverride with relations to user, permission,
grantedBy; isExpired() helper.

== Resolution order in User::canDo() ==
1. Active deny-override (not expired) → return false (and log if sensitive)
2. Active grant-override (not expired) → return true
3. Admin/owner bypass → return true
4. Standard role-based check via Spatie

Critically: deny overrides ALSO block admin/owner. This is intentional —
the TZ's "separation of duties" requirement (an admin who shouldn't be
able to delete payments). Without this, deny is useless against admins.

Override resolution uses a single query per check (cached by Eloquent
during the request). The override-check happens before the role check
so a deny is always authoritative.

== Audit log on sensitive denials ==
When canDo() returns false for one of these sensitive permissions, a
spatie/activitylog entry is written with event=permission_denied:
- admin.users.manage / admin.roles.manage / admin.settings.edit
  / admin.backup.download
- finance.delete_payment / finance.view_pl
- salaries.mark_paid / salaries.view_all
- work_orders.delete / work_orders.approve_discount_any

Non-sensitive denials (e.g., clients.create) don't log to avoid noise.
The activity payload includes the permission slug; causedBy is the user
who was denied. Failures of the logger are swallowed so a misconfigured
activitylog never breaks auth.

== UserResource UI ==
New PermissionOverridesRelationManager mounted on the edit page:
- Table: permission, mode (GRANT/DENY badge), reason, expires_at,
  granted_by
- Create form: permission select, mode, expires_at, reason
- granted_at + granted_by_id auto-populated to now() / auth()->id()
- Default sort: granted_at desc

Two new actions on the user row:
- "Force logout" (warning color): visible only when active sessions
  exist. Deletes every row in `sessions` with user_id=record→id.
  Notification shows count revoked.
- "Resetează 2FA" stays (from previous commit)

Two new toggleable columns:
- Sesiuni active (count from sessions table)
- Excepții (count of permission overrides)

== Tests ==
PermissionOverridesTest covers:
- grant unlocks a permission the role doesn't have
- deny blocks a permission the role grants
- deny blocks even admin role (separation of duties)
- expired override is ignored
- future-expiry override stays active
- audit log writes on sensitive denial
- audit log silent on non-sensitive denial
- force_logout deletes all user sessions but not others'

Suite: 214 passed (591 assertions). Was 206.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-04 22:27:20 +00:00
parent 58004b65c4
commit 1d4ac3db38
6 changed files with 411 additions and 3 deletions
+57 -3
View File
@@ -11,6 +11,7 @@ use Filament\Panel;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\SoftDeletes;
use Illuminate\Foundation\Auth\User as Authenticatable;
use Illuminate\Database\Eloquent\Relations\HasMany;
use Illuminate\Notifications\Notifiable;
use Laravel\Sanctum\HasApiTokens;
use Spatie\Permission\Traits\HasRoles;
@@ -78,18 +79,71 @@ class User extends Authenticatable implements FilamentUser, HasAppAuthentication
return in_array($this->role, ['mechanic', 'master'], true) || $this->hasAnyRole(['mechanic']);
}
/** Shortcut for permission check using App\Auth\Permissions slug. */
public function permissionOverrides(): HasMany
{
return $this->hasMany(UserPermissionOverride::class);
}
/**
* Permission check honoring (in order):
* 1. Active deny-override false
* 2. Active grant-override true
* 3. Admin/owner bypass true
* 4. Standard role-based check
*/
public function canDo(string $permission): bool
{
// Owner + admin always pass — safety net for misconfigured permission grants.
$override = $this->activeOverrideFor($permission);
if ($override) {
if ($override->mode === 'deny') {
$this->logDeniedIfSensitive($permission);
return false;
}
if ($override->mode === 'grant') return true;
}
// Owner + admin bypass for permissions without explicit deny.
if ($this->isAdmin()) return true;
try {
return $this->can($permission);
$allowed = $this->can($permission);
if (! $allowed) $this->logDeniedIfSensitive($permission);
return $allowed;
} catch (\Throwable $e) {
return false;
}
}
private function activeOverrideFor(string $permissionSlug): ?UserPermissionOverride
{
return $this->permissionOverrides()
->whereHas('permission', fn ($q) => $q->where('name', $permissionSlug))
->where(fn ($q) => $q->whereNull('expires_at')->orWhere('expires_at', '>', now()))
->first();
}
/** Sensitive permissions whose deny we should record for audit. */
private const AUDITED_DENIALS = [
'admin.users.manage', 'admin.roles.manage', 'admin.settings.edit', 'admin.backup.download',
'finance.delete_payment', 'finance.view_pl',
'salaries.mark_paid', 'salaries.view_all',
'work_orders.delete', 'work_orders.approve_discount_any',
];
private function logDeniedIfSensitive(string $permission): void
{
if (! in_array($permission, self::AUDITED_DENIALS, true)) return;
try {
activity('permissions')
->causedBy($this)
->withProperties(['permission' => $permission])
->event('permission_denied')
->log("permission denied: $permission for user #{$this->id}");
} catch (\Throwable $e) {
// activity-log may be misconfigured in some contexts — never let auth fail because of it.
}
}
/** Has 2FA app authentication enabled (Filament native). */
public function hasTwoFactorEnabled(): bool
{