From 346fcf968f5ffdd5aedfd43c33fb833fecf183be Mon Sep 17 00:00:00 2001
From: Vasyka <vasyka.moraru@gmail.com>
Date: Tue, 1 Sep 2026 11:04:24 +0000
Subject: [PATCH] =?UTF-8?q?fix(faq):=20toggle=20worked=20server-side=20but?=
 =?UTF-8?q?=20click=20did=20nothing=20=E2=80=94=20nested=20forms?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Filament pages wrap their content in an outer <form>. My inline
<form method="POST"> for the hint toggle + reset was nested inside
that outer form — invalid HTML, so browsers dropped my submit and
either did nothing or ran the outer Livewire form's handler.

Replaced both forms with plain <button type="button"> + onclick
fetch() POST + window.location.reload(). Controller now also returns
JSON when Accept: application/json (fetch sends that) instead of a
back() redirect.

The server-side flip was always correct — verified via a Feature
test that posts to /app/hints/toggle and asserts the user column
flipped from true → false.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 app/Http/Controllers/HintController.php       |  6 +++
 .../views/filament/tenant/pages/faq.blade.php | 43 ++++++++++++-------
 2 files changed, 33 insertions(+), 16 deletions(-)

diff --git a/app/Http/Controllers/HintController.php b/app/Http/Controllers/HintController.php
index b91a11b..b89a00f 100644
--- a/app/Http/Controllers/HintController.php
+++ b/app/Http/Controllers/HintController.php
@@ -26,6 +26,9 @@ class HintController extends Controller
         abort_unless($user, 401);
         $user->hints_enabled = ! $user->hints_enabled;
         $user->save();
+        if ($request->expectsJson()) {
+            return response()->json(['ok' => true, 'hints_enabled' => (bool) $user->hints_enabled]);
+        }
         return back();
     }
 
@@ -37,6 +40,9 @@ class HintController extends Controller
         $user->dismissed_hints = [];
         $user->hints_enabled = true;
         $user->save();
+        if ($request->expectsJson()) {
+            return response()->json(['ok' => true]);
+        }
         return back();
     }
 }
diff --git a/resources/views/filament/tenant/pages/faq.blade.php b/resources/views/filament/tenant/pages/faq.blade.php
index ad6dee8..cca6f9a 100644
--- a/resources/views/filament/tenant/pages/faq.blade.php
+++ b/resources/views/filament/tenant/pages/faq.blade.php
@@ -306,23 +306,34 @@
         <input type="text" class="faq-search" placeholder="{{ __('Caută în ghid...') }}" wire:model.live.debounce.300ms="search">
         <div class="faq-toggle">
             <span class="faq-toggle-lbl">{{ __('Sugestii „?" pe pagini:') }}</span>
-            <form method="POST" action="{{ route('hints.toggle') }}" style="display:inline-flex;align-items:center;">
-                @csrf
-                <button type="submit" class="faq-switch {{ $user?->hints_enabled ? 'on' : 'off' }}"
-                        title="{{ $user?->hints_enabled ? __('Click pentru a DEZACTIVA') : __('Click pentru a ACTIVA') }}"
-                        aria-label="{{ __('Toggle hints') }}">
-                </button>
-                <span class="faq-switch-lbl {{ $user?->hints_enabled ? 'on' : 'off' }}">
-                    {{ $user?->hints_enabled ? __('ACTIVE') : __('DEZACTIV') }}
-                </span>
-            </form>
-            <form method="POST" action="{{ route('hints.reset') }}" style="display:inline;">
-                @csrf
-                <button type="submit" class="faq-btn-reset" title="{{ __('Aduce înapoi hint-urile ascunse') }}">
-                    ↻ {{ __('Resetează') }}
-                </button>
-            </form>
+            <button type="button"
+                    class="faq-switch {{ $user?->hints_enabled ? 'on' : 'off' }}"
+                    title="{{ $user?->hints_enabled ? __('Click pentru a DEZACTIVA') : __('Click pentru a ACTIVA') }}"
+                    aria-label="{{ __('Toggle hints') }}"
+                    onclick="faqPostAction('{{ route('hints.toggle') }}')"></button>
+            <span class="faq-switch-lbl {{ $user?->hints_enabled ? 'on' : 'off' }}">
+                {{ $user?->hints_enabled ? __('ACTIVE') : __('DEZACTIV') }}
+            </span>
+            <button type="button"
+                    class="faq-btn-reset"
+                    title="{{ __('Aduce înapoi hint-urile ascunse') }}"
+                    onclick="faqPostAction('{{ route('hints.reset') }}')">
+                ↻ {{ __('Resetează') }}
+            </button>
         </div>
+        <script>
+        function faqPostAction(url) {
+            fetch(url, {
+                method: 'POST',
+                headers: {
+                    'X-CSRF-TOKEN': '{{ csrf_token() }}',
+                    'Accept': 'application/json',
+                    'X-Requested-With': 'XMLHttpRequest',
+                },
+                credentials: 'same-origin',
+            }).then(() => window.location.reload()).catch(() => window.location.reload());
+        }
+        </script>
     </div>
 
     {{-- GRID --}}