'test'], ['name' => 'T', 'price' => 0, 'features' => []]); $this->company = Company::create(['plan_id' => $plan->id, 'slug' => 'im-' . uniqid(), 'name' => 'IM', 'status' => 'active']); app(TenantManager::class)->setCurrent($this->company); app(RbacSeeder::class)->seedTenantRoles($this->company->id); app(PermissionRegistrar::class)->setPermissionsTeamId($this->company->id); $this->mechanic = User::create(['name' => 'Andrei', 'email' => 'a@e.com', 'password' => bcrypt('x'), 'role' => 'mechanic', 'status' => 'active', 'internal_margin_pct' => 20.00]); $client = Client::create(['name' => 'C', 'phone' => '+37399000000', 'type' => 'individual', 'status' => 'active']); $vehicle = Vehicle::create(['client_id' => $client->id, 'make' => 'BMW', 'model' => 'X5', 'plate' => 'IM-1']); $this->wo = WorkOrder::create([ 'number' => WorkOrder::generateNumber($this->company->id), 'client_id' => $client->id, 'vehicle_id' => $vehicle->id, 'master_id' => $this->mechanic->id, 'opened_at' => today(), 'status' => 'in_work', 'total' => 0, ]); } // ─── MarginResolver fallback chain ─── public function test_margin_resolver_uses_wo_override_first(): void { $this->wo->override_margin_pct = 30; $resolver = app(MarginResolver::class); $this->assertEquals(30.0, $resolver->resolve($this->wo, $this->mechanic)); } public function test_margin_resolver_falls_back_to_mechanic(): void { // No WO override → mechanic's 20% $this->assertEquals(20.0, app(MarginResolver::class)->resolve($this->wo, $this->mechanic)); } public function test_margin_resolver_falls_back_to_company_default(): void { $bareUser = User::create(['name' => 'B', 'email' => 'b@e.com', 'password' => bcrypt('x'), 'role' => 'mechanic', 'status' => 'active']); $this->company->update(['settings' => ['default_internal_margin_pct' => 15]]); app(TenantManager::class)->setCurrent($this->company->fresh()); $this->assertEquals(15.0, app(MarginResolver::class)->resolve($this->wo, $bareUser)); } public function test_margin_resolver_returns_zero_when_nothing_configured(): void { $bareUser = User::create(['name' => 'C', 'email' => 'c@e.com', 'password' => bcrypt('x'), 'role' => 'mechanic', 'status' => 'active']); $this->assertEquals(0.0, app(MarginResolver::class)->resolve($this->wo, $bareUser)); } // ─── salary_base freeze semantics ─── public function test_saving_work_freezes_salary_base_at_20_percent_off(): void { // client_price 250 · marja 20% → salary_base 200 (= 250 × 0.80) $work = WorkOrderWork::create([ 'work_order_id' => $this->wo->id, 'master_id' => $this->mechanic->id, 'name' => 'Diagnoză', 'hours' => 1, 'price_per_hour' => 250, ]); $this->assertEquals(250.00, (float) $work->total); $this->assertEquals(200.00, (float) $work->salary_base); $this->assertEquals(20.00, (float) $work->applied_margin_pct); } public function test_changing_mechanic_margin_later_does_not_rewrite_history(): void { // Create work at 20% → salary_base=200 $work = WorkOrderWork::create([ 'work_order_id' => $this->wo->id, 'master_id' => $this->mechanic->id, 'name' => 'X', 'hours' => 1, 'price_per_hour' => 250, ]); $originalBase = (float) $work->salary_base; // Manager changes mechanic's margin to 40% RETROACTIVELY $this->mechanic->update(['internal_margin_pct' => 40]); // Freshly loaded work should still have the old salary_base $reload = WorkOrderWork::find($work->id); $this->assertEquals($originalBase, (float) $reload->salary_base); $this->assertEquals(20.00, (float) $reload->applied_margin_pct); } public function test_updating_total_recomputes_salary_base_with_current_margin(): void { $work = WorkOrderWork::create([ 'work_order_id' => $this->wo->id, 'master_id' => $this->mechanic->id, 'name' => 'X', 'hours' => 1, 'price_per_hour' => 250, ]); // Change price → total becomes 500 → salary_base recomputes at current margin (20%) $work->update(['price_per_hour' => 500]); $work->refresh(); $this->assertEquals(500.00, (float) $work->total); $this->assertEquals(400.00, (float) $work->salary_base); } // ─── PayrollCalculator uses salary_base ─── public function test_payroll_uses_salary_base_not_total(): void { Carbon::setTestNow('2026-07-10'); EmployeeProfile::create([ 'user_id' => $this->mechanic->id, 'base_salary' => 0, 'works_pct' => 50, 'parts_pct' => 0, ]); WorkOrderWork::create([ 'work_order_id' => $this->wo->id, 'master_id' => $this->mechanic->id, 'name' => 'X', 'hours' => 1, 'price_per_hour' => 250, 'status' => 'done', ]); $run = app(PayrollCalculator::class)->compute($this->mechanic->id, '2026-07'); // 50% of salary_base=200 → 100 (NOT 50% of total=250 → 125) $this->assertEquals(100.0, (float) $run->works_pct_amount); Carbon::setTestNow(); } public function test_payroll_falls_back_to_total_when_salary_base_null(): void { // Simulate legacy WOs from before this feature by clearing salary_base Carbon::setTestNow('2026-07-10'); EmployeeProfile::create(['user_id' => $this->mechanic->id, 'base_salary' => 0, 'works_pct' => 50, 'parts_pct' => 0]); $work = WorkOrderWork::create([ 'work_order_id' => $this->wo->id, 'master_id' => $this->mechanic->id, 'name' => 'X', 'hours' => 1, 'price_per_hour' => 100, 'status' => 'done', ]); // Manually null out salary_base \DB::table('wo_works')->where('id', $work->id)->update(['salary_base' => null, 'applied_margin_pct' => null]); $run = app(PayrollCalculator::class)->compute($this->mechanic->id, '2026-07'); // Falls back to total: 50% of 100 → 50 $this->assertEquals(50.0, (float) $run->works_pct_amount); Carbon::setTestNow(); } // ─── Contract: NO leak in client-facing surfaces ─── public function test_workorder_pdf_does_not_leak_salary_base_or_margin(): void { WorkOrderWork::create([ 'work_order_id' => $this->wo->id, 'master_id' => $this->mechanic->id, 'name' => 'Diagnoză computer', 'hours' => 1, 'price_per_hour' => 250, 'status' => 'done', ]); $pdf = app(WorkOrderPdfService::class)->generate($this->wo->fresh()); $output = $pdf->output(); // Strings that MUST NOT appear in a client-facing PDF: $forbidden = ['salary_base', 'internal_margin', 'applied_margin_pct', 'marja intern', 'Bază salariu']; foreach ($forbidden as $needle) { $this->assertStringNotContainsString( $needle, $output, "Client-facing PDF leaked internal-margin term: $needle" ); } } public function test_tracking_json_does_not_leak_salary_or_margin(): void { WorkOrderWork::create([ 'work_order_id' => $this->wo->id, 'master_id' => $this->mechanic->id, 'name' => 'Diagnoză', 'hours' => 1, 'price_per_hour' => 250, 'status' => 'done', ]); $resp = $this->getJson("/api/track/{$this->wo->tracking_token}"); $resp->assertOk(); $body = json_encode($resp->json()); foreach (['salary_base', 'internal_margin', 'applied_margin', 'override_margin'] as $needle) { $this->assertStringNotContainsString($needle, $body, "Tracking JSON leaked: $needle"); } } // ─── Applies only to labor, not parts ─── public function test_parts_are_not_affected_by_internal_margin(): void { // Add a part — should NOT get salary_base column touched $part = WorkOrderPart::create([ 'work_order_id' => $this->wo->id, 'name' => 'Filtru', 'qty' => 1, 'sell_price' => 250, 'buy_price' => 100, ]); // The wo_parts table doesn't even have a salary_base column $this->assertFalse(\Schema::hasColumn('wo_parts', 'salary_base')); } public function test_wo_override_wins_over_mechanic_margin(): void { $this->wo->update(['override_margin_pct' => 40]); // WO-specific $work = WorkOrderWork::create([ 'work_order_id' => $this->wo->id, 'master_id' => $this->mechanic->id, 'name' => 'X', 'hours' => 1, 'price_per_hour' => 250, ]); // Should use 40% not 20% → salary_base = 250 × 0.60 = 150 $this->assertEquals(150.00, (float) $work->salary_base); $this->assertEquals(40.00, (float) $work->applied_margin_pct); } }